Announcement
Collapse
No announcement yet.
Need a dev to implement these BASK template changes so that we can patch to 10.04
Collapse
X
-
Levels doesn't have the "basket undo" functionality built in the way that Shadows does -- so no template changes are needed there. You might still do a template search and replace (not sure if these entities are in use):
Search for:
&mvt:global:invalid_credentials;
Replace with:
&mvte:global:invalid_credentials;
https://github.com/mivaecommerce/rea...ows/issues/129
-Ryan
Comment
-
Hi Ryan,
Just confirming my conclusion is correct. Stores that have this UNDO capability in BASK need its template code updated? That actually makes the lines of code that are highlighted, with the Restore style variables, make sense.
Also want to make sure there is no other reasons.
Thanks,
ScottNeed to offer Shipping Insurance?
Interactive Design Solutions https://www.myids.net
MivaMerchant Business Partner | Certified MivaMerchant Web Developer
Competitive Rates, Custom Modules and Integrations, Store Integration
AutoBaskets|Advanced Waitlist Integration|Ask about Shipping Insurance Integration
My T-shirt Collection is mostly MivaCon T-shirts!!
Comment
-
As far as I'm aware... yes. I've only been working with the Shadows RT for the last couple years. That said, unless the store was built with Luxe, Colossus, or Shadows you shouldn't need to worry about the template update (as those are the only three themes to include the 'UNDO capability').
The recent updates seem to address unencoded entities/variables. I'm sure Miva will post additional updates if they're required for other themes... You just want to make sure that any entities used for inputs etc. are encoded (&mvte:).
Definitely do the search & replace as stated above – it applies to more themes than just Shadows.
-Ryan
Comment
-
Thanks, Ryan. This answer reminded me I have a client's store using Colossus.
Scott
Need to offer Shipping Insurance?
Interactive Design Solutions https://www.myids.net
MivaMerchant Business Partner | Certified MivaMerchant Web Developer
Competitive Rates, Custom Modules and Integrations, Store Integration
AutoBaskets|Advanced Waitlist Integration|Ask about Shipping Insurance Integration
My T-shirt Collection is mostly MivaCon T-shirts!!
- 1 like
Comment
-
Originally posted by RTHOMASDESIGN View PostLevels doesn't have the "basket undo" functionality built in the way that Shadows does -- so no template changes are needed there. You might still do a template search and replace (not sure if these entities are in use):
Search for:
&mvt:global:invalid_credentials;
Replace with:
&mvte:global:invalid_credentials;
https://github.com/mivaecommerce/rea...ows/issues/129
-Ryan
value="&mvt:
and replace with
value="&mvte:
A couple of older sites we've done recently usually have a half dozen or more of these...and in general, input values should all be encoded.Bruce Golub
Phosphor Media - "Your Success is our Business"
Improve Your Customer Service | Get MORE Customers | Edit CSS/Javascript/HTML Easily | Make Your Site Faster | Get Indexed by Google | Free Modules | Follow Us on Facebook
phosphormedia.com
- 1 like
Comment
-
Originally posted by Bruce - PhosphorMedia View Post
One might also suggest doing a S&R for
value="&mvt:
and replace with
value="&mvte:
A couple of older sites we've done recently usually have a half dozen or more of these...and in general, input values should all be encoded.Leslie Kirk
Miva Certified Developer
Miva Merchant Specialist since 1997
Previously of Webs Your Way (aka Leslie Nord leslienord)
Email me: [email protected]
www.lesliekirk.com
Follow me: Twitter | Facebook | FourSquare | Pinterest | Flickr
Comment
-
Those are for inputs and the exact purpose of enconding them is to PREVENT people from entering html...like "script..."Bruce Golub
Phosphor Media - "Your Success is our Business"
Improve Your Customer Service | Get MORE Customers | Edit CSS/Javascript/HTML Easily | Make Your Site Faster | Get Indexed by Google | Free Modules | Follow Us on Facebook
phosphormedia.com
Comment
-
Originally posted by RTHOMASDESIGN View PostLevels doesn't have the "basket undo" functionality built in the way that Shadows does -- so no template changes are needed there. You might still do a template search and replace (not sure if these entities are in use):
Search for:
&mvt:global:invalid_credentials;
Replace with:
&mvte:global:invalid_credentials;
https://github.com/mivaecommerce/rea...ows/issues/129
-RyanLeslie Kirk
Miva Certified Developer
Miva Merchant Specialist since 1997
Previously of Webs Your Way (aka Leslie Nord leslienord)
Email me: [email protected]
www.lesliekirk.com
Follow me: Twitter | Facebook | FourSquare | Pinterest | Flickr
Comment
-
Originally posted by lesliekirk View Post
I'm working on a Levels site that DOES have the undo function. perhaps it was a custom addition? But anywho, I'm going to start a new post for it.
https://www.miva.com/assets/template..._10.04.00.html
The primary difference is the encoding. The doc above should make it pretty easy to update any site that has the undo function :)
-Ryan
Comment
-
Originally posted by RTHOMASDESIGN View Post
If you look at the template changes here:
https://www.miva.com/assets/template..._10.04.00.html
The primary difference is the encoding. The doc above should make it pretty easy to update any site that has the undo function :)
-RyanLeslie Kirk
Miva Certified Developer
Miva Merchant Specialist since 1997
Previously of Webs Your Way (aka Leslie Nord leslienord)
Email me: [email protected]
www.lesliekirk.com
Follow me: Twitter | Facebook | FourSquare | Pinterest | Flickr
- 1 like
Comment
-
Originally posted by lesliekirk View Post
FYI Matt shared this for a "bare bones" Levels https://gist.github.com/influxweb/75...d8c3ce7b6eec0a
-Ryan
Comment
Comment