Need To Shorten Conditional

[greggc]

I have the following conditional to hide loyalty points from displaying on the product page. I need to add additional products to this. Can someone advise as how to possibly shorten this? Appreciate the help.

<mvt:if expr="(l.settings:product:code NE 'e-gift-cert' AND l.settings:product:code NE 'gift-cert' AND l.settings:product:code NE 'HKW-1' AND l.settings:product:code NE '662434-83' AND l.settings:product:code NE 'O17-1')"></mvt>

[Kent Multer]

This is a bit convoluted, but it's what I do in that situation:

<mvt:if expr="NOT ( (',' $ l.settings:product:code $ ',') CIN (',e-gift-cert,gift-cert,HKW-1,662434-83,O17-1,AnotherCode,OneMoreCode,YetAnotherCode,EtcEtc,') )">

The extra commas are needed so that it won't accidentally detect a short code that happens to be a substring of a larger one in the list. Note that there are commas at the beginning and end of both strings.

[greggc]

Thanks Kent.

[Bruce - PhosphorMedia]

Yes, this is how it always should be done. If this is something an Admin may want to update, we'd typically write it like this:

<mvt:assign name="g.dont_show_points" value="'this_code, that_code, another_code'" />

<mvt:if expr="NOT(', ' $ l.settings:product:code CIN g.dont_show_points)">
points
</mvt:if>

this, in our experiance, makes Admin entry less prone to breaking things. At most, you get a false 'positive' in stead of breaking the conditional altogether.