CSS "bleed over"

[lesliekirk]

I am having issues with sites (this will be the third one now) that is having issues with CSS styles crossing over. The latest store is a true dev so I can't show you what I'm seeing. Because I had had issues with another changing the Framework of branch to Shadows 10.05 from a custom Framework (it had CSS conflicts all over the place) I went back to it and created a branch with Shadows 10.04, then applied Shadows 10.05 to it. That seemed to solve the problem with the second store. Now this dev site had Shadows 10.04 which I have chugging along building a new look & feel in. It was not a fresh install but a copy of the live site which had been built using the Base ReadyTheme. There were no issues with the Shadows 10.04 branch so I created a new branch from it and applied Shadows 10.05 to it. Now the CSS from Shadows 10.05 is showing up in the Production branch display. It's really easy to tell that it's CSS from Shadows 10.05 because it's using the grid-template-columns.

This is not the correct CSS for Shadows 10.04

[CODE].x-product-list {
grid-template-columns: repeat(4, minmax(0, 1fr));
}

.x-product-list, .x-subcategory-list {
display: grid;
gap: calc(var(--default-spacing-unit) * 2);}/CODE]

I'm going to have to request that support do a roll back to restore everything to what it was. This is my third encounter with CSS issues.

[Brennan]

There is a bug in PageBuilder related to heading tags getting overwritten: Here is the template changes to fix it. We'll be fixing it in 10.05.03: https://docs.miva.com/pagebuilder-bug-fixes

[lesliekirk]

There is a bug in PageBuilder related to heading tags getting overwritten: Here is the template changes to fix it. We'll be fixing it in 10.05.03: https://docs.miva.com/pagebuilder-bug-fixes

Brennan - will this fix also prevent the CSS and Javascript files from being overwritten? I have confirmed that one of the sites I was having this issue with has had a number of the files in the Production Branch overwritten by an attempt to add the Shadows 10.05 to a different Branch.

Some of the files that were overwritten in the httpdocs/mm5/themes/00000001/shadows directory include:

core.css
core.js
extensions.css
extensions.js
theme.css
theme.js

[Brennan]

The issue you're seeing is related to applying the Shadows Framework to the store. But yes when we address it, it will solve it for both CSS and JS.

[lesliekirk]

The issue you're seeing is related to applying the Shadows Framework to the store. But yes when we address it, it will solve it for both CSS and JS.

Yes, it was being applied to make it easier for the store owner to jump right in and start playing with PageBuilder (which by the way is loving it). Hence the post in the PageBuilder forum.

[Brennan]

The core issue here is when applying a framework to a site, the resources (CSS/JS) are created in a non-branch specific path overwriting the primary branch with those files. If applying a completely different framework than what the primary branch uses may be safer in most cases as they may not share resources names/paths. However, if applying a new version of a framework, for example shadows and the production branch also uses Shadows it will unintentionally overwrite the files on production.

Until this is fixed, a framework should not be applied to a branch on a production store to avoid accidentally overwriting files.